Support Ticket

+status
+tags
 

There is a view option, no_wrap_comment that will suppress comments that Wagn inserts into generated card content.  I'm not sure which views get this processing, but the default behavior is to insert these comments and also to indent the html with spaces.

 

It's noisy and it gets in the way in many places.  DOM inspectors to a fine job of formatting and IMHO, this just adds noise when debugging.

 

I had no idea what you were talking about here; had to look into code to understand. I'll rewrite this ticket so that someone could understand it without looking at the code.

 

We can do this. I also think we should be able to produce HTML that's readable without a DOM inspector, Mr. I. Hate GUIs :). Note that the wrap achieves not only comments but also appropriate white space handling so that humans can understand the data. Gimme that old time unix religion.

--Ethan McCutchen.....2013-12-23 16:39:57 +0000

There are places where this is absolutely a bug. I recently ran into it when trying to use inclusions in some embed code. I was trying to do a quick example of how to make a cardtype template to embed a YouTube video, and the comments invaded the URL.

--Gerry Gleason.....2013-12-23 16:42:56 +0000

Readability is overrated for generated HTML. For debugging javascript, css and html generated, there really isn't any other way than to use the dev-tools of a modern browser.

--Gerry Gleason.....2013-12-23 16:45:36 +0000

Then I suspect you were using the wrong view. You only get that html comment if you get a slot (a div). If you wanted the raw url and were just doing a default (content view) inclusion, you were screwed with or without the comment.

--Ethan McCutchen.....2013-12-23 16:46:15 +0000

I'm also noticing that content seems to be wrapped twice in a div with class=card-content. It's beginning to matter a bit to me because I'm playing with code to do 'live-editing' on the HTML directly. This is the 'better than just grafting on etherpad' idea.

--Gerry Gleason.....2013-12-23 16:50:58 +0000

I think I tried a raw view, but that was a few weeks back now.

--Gerry Gleason.....2013-12-23 16:52:21 +0000

I think I know how to do this, you want me to make a PR for it?

--Gerry Gleason.....2013-12-23 22:21:45 +0000

Sure you could make a PR. I won't really be back at work until Jan 6.

 

The card wrapping is quite clean now, so if you've got two card-content divs, they're probably both right.

--Ethan McCutchen.....2013-12-24 23:54:41 +0000

will change this to a ticket. Gerry already made a PR.

--Ethan McCutchen.....2014-01-09 23:19:10 +0000