Ticket
make w- classes safe from stripping+issues
we've been letting classes beginning with w- through on spans but not other html tags, which means some things that rely on these classes (like spotlight and highlight) are getting stripped.
make w- classes safe from stripping+solution
make w- classes safe on all tags.
make w- classes safe from stripping+example
should check connectipedia discussion for examples.
Not seeing how to test this. And fyi, doesn't look like this ticket will address the problem on Connectipedia anyway - the problem described on connectipedia+discussion doesn't seem to be about stripping, and is showing up at http://www.connectipedia.org/wagn/John_Abbe+my_space even though the highlight/spotlight w- bits are in spans (and the italics showing up as highlight in edit mode is just weird).
how to test:
edit html and insert a class that begins with "w-" into a p tag.
The problems does seem to be about stripping. Before we were stripping classes from everything BUT spans, even if they started with w-. So, if tinyMCE put the class on a p tag, for example, it got stripped. You can probably reproduce this by highlighting or spotlighting an entire paragraph.
--Ethan McCutchen.....Thu May 21 15:57:51 -0700 2009
I tested stripping here http://test.dwagn.org/wagn/w_stripping_test and it looks fine. I copied the spotlight/highlight code from Connectipedia's css, with some odd results you can see (highlight and spotlight lines running together). It only affects view mode, so i assume the edit mode stuff is done somewhere other than *css? (Is this true in general, e.g. for styling h1 and h2?)
Are we talking about the same Connectipedia problem - where in edit mode em tags displays as highlight, and w-highlight displays as spotlight? I may be missing something here, but i'm still not seeing how this ticket addresses that.
--John Abbe.....Fri May 22 12:14:09 -0700 2009
ah, ok. I was only seeing part of the issue.
Short answer is that tinyMCE is generally not now getting the css from *css. Could you ticket that? It shouldn't be that hard to fix, though currently it's configured separately in each *tinyMCE, and to be less flaky we need a true "raw" view. I actually fixed a bunch of cp's issue just now - their problem was that tinyMCE was taking css from their old local.css, which did use the italics.
So, afaik, spotlight / highlight is fixed on cp, but it's flaky, and you could actually break it by adding comments to *css (because we don't have raw view).
--Ethan McCutchen.....Sat May 23 14:36:59 -0700 2009
in any case, I think this ticket's ready to close.
--Ethan McCutchen.....Sat May 23 14:37:18 -0700 2009
have tinymce pull css from *css
Closing, and emailing remaining Connectipedia issues.
--John Abbe.....Sat May 23 15:54:00 -0700 2009