remove attribute-less spans

Ticket

+status
+priority
+commit
 
+issue

blank spans can screw up inclusion syntax, eg \{<span>{</span>cardname}}

 

+solution

quick solution may be to use extended_valid_elements in tinyMCE (see required attribs in valid_elements)

 

 

expand_less +discussion

are you seeing associated problems? Even an attributeless span can be significant to CSS, so we may cause some problems by removing them. But worth exploring.

 --Ethan McCutchen.....Tue Feb 01 09:26:33 -0800 2011

 


 

I'm pretty sure I've seen messes created by a bunch of nested attribute-less spans. When you say we could cause problems, you mean there's CSS thet depends on nested spans that have been inserted into cards' HTML? I'm not suggesting removing any spans from outside of card content.

 --John Abbe, Feb 01 2011


yup, was just bit by this again - sucky waste of time.

  --John Abbe.....Tue Feb 08 13:50:05 -0800 2011


Note that this should be checked after the HTML is "cleaned".

 

As long as we're at it, remove attribute-less divs as well? Or ticket separately?

  --John Abbe.....Fri Feb 11 21:29:59 -0800 2011


link showing red, seems like mistake

  --John Abbe.....Fri Feb 18 00:01:23 -0800 2011


just wasted 10 mins on this again, we hates it

(the blank line in Recent Changes is no doubt from this, for a card named something like |span||span|coded, but replace the |s with less than and greater than signs)

  --John Abbe.....Sat Feb 19 16:59:32 -0800 2011


This could be some more advanced code when cleaning. That's the point at which we know we have empty elements. Also, might be nice to do cleaning (when it is enabled for a card being edited) at one or both of the transitions from/to the HTML editor. That way you don't have to save the card to find out what will be filtered.

--Gerry Gleason.....2013-06-08 18:16:08 +0000