close fullscreen

 

See http://sandwagn.wagn.org/wagn/inclusion_test

  --John Abbe.....Mon Jun 09 15:30:44 -0700 2008

Closed this duplicate: render_newly_created_inclusions_in_correct_view.

  --Ethan McCutchen.....Mon Dec 15 16:27:55 -0800 2008

I think there may still be work on #4, though the error is more intelligible now. It would take significant refactoring to make that work, so I think it's probably a good candidate for a new ticket.

  --Ethan McCutchen.....Thu Jan 29 16:36:03 -0800 2009

See http://sandbox.wagn.org/wagn/inclusion_test for #1 and #2 here:

#1 - double-click on the text of an included view:closed card to edit it. Cancel, and you get view:open.

#2 is still a problem if you change cardtypes. Even without changing cardtype, if an inclusion is view:closed, after creation it shows as view:open. See discussion on default image inclusions to display inline

#3 - cool!

#4 - will ticket as per Ethan's comment. What do i call the new ticket? render created inclusions as normal cards?

  --John Abbe.....Tue Feb 10 15:52:03 -0800 2009

 

#1 is intentional. Once a card is opened, the only thing that closes it is the close button.
#2 re the open/closed thing, that's intentional. In fact, you lobbied for that! I'll have a look at the cardtype thing.
#3 still cool.
#4 I'll ticket it. It's really a refactoring issue.

  --Ethan McCutchen.....Wed Feb 11 10:37:57 -0800 2009

The following few comments were moved here from default image inclusions to display inline

  • the light grey text thing is not an easy fix. Lew and I have some restructuring in mind that will fix it. Issue has to do with updating / replacing slots. I might be able to hack a fix, though, if it seems like a big deal...
  • can you reproduce the view:open thing? I haven't seen that, and I don't know any reason why card type would affect that. My guess is that it has to do with *changing* the cardtype. Is it open any time you change the cardtype in the process of adding? If so, this may or may not be a quick fix. Worth a check.
  • I just fixed several cases where the horizontal

--Ethan McCutchen.....Mon Feb 09 22:34:33 -0800 2009

Gray text doesn't seem like a big deal to me, we just need to let people know the rendering after creating cards is imperfect and a reload will fix it. Is the updating / replacing slots issue what will be addressed by the new ticket mentioned in +discussion, or is it a different new ticket?

Will try to reproduce view:open thing.

And test horizontal space issue when you let me know that the fixes are up for testing.

  --John Abbe.....Tue Feb 10 01:49:26 -0800 2009

Your guess re view:open is correct - any change of type before creation results in the view rendering as open.

  --John Abbe.....Tue Feb 10 03:07:03 -0800 2009

 

So todos here:
1. check on the grey text thing.
2. check on the changing cardtype thing.
3. ticket the refactoring issue.

  --Ethan McCutchen.....Wed Feb 11 10:41:56 -0800 2009

4. oh, and IE testing

  --Ethan McCutchen.....Wed Feb 11 11:58:33 -0800 2009

I fixed #1 and #2, and #3 is on my personal todo list (no need to hold this up for it).

We can't close this until we know IE is working properly, but let's test the other stuff.

  --Ethan McCutchen.....Wed Feb 11 13:17:43 -0800 2009

I *think* i have things going in IE. check it out on sand*

  --Lewis Hoffman.....Thu Feb 12 17:32:02 -0800 2009

In IE6 - http://sandwagn.wagn.org/wagn/make_me_a_card :

 

Nothing happens when i click on "Add <cardname>"

 

Phrase/Plaintext inclusions have problems at the beginning and end: they start with a new line, and delete the horizontal space after them.

 

Unrelated(?) visual bugs (in IE6):

White stripe at the top of cards in the sidebar.

Long card titles get pushed left to overlap triangle icon.

 

Will test IE7 tomw night or Sunday morning.

 

Everything tests ok in Safari.

 

p.s. Took a little getting used to, but i like the SMALL CAPS for inclusions.

  --John Abbe.....Fri Feb 13 23:53:30 -0800 2009

In IE6: I can create inclusions now, but even after reloading they're starting on a new line; and they have no space right after them, even though there is in the including card.

  --John Abbe.....Tue Feb 17 21:31:03 -0800 2009