I did these three, and in the process I made a couple of other changes:

• I added a scope (set to :login) to validates_uniqueness, so that users with "logins" (which are really more like "codenames" now) can have the same email as an actual user.  So, for example, I could create a new wagn and have my Wagn Bot use ethan@grasscommons.org, while still using that email for my personal account.
• I had the migration get rid of logins for all the accounts that used to have them
• I also had the migration set status to "system" on wagn bot and anon cards, so that they don't require passwords.  This gets them in line with the way we're installing them now.

---

you know, I could've migrated all account requests to have the "pending" status, but I'm guessing this one will sort itself out.

  --Ethan McCutchen.....Sun Nov 15 16:38:39 -0800 2009

---

migrations have been run on ang. fwiw, migrations there seem to be breaking on several dwagns:

 

osoeco, orchard, new2, earlysteps, grouppatterns. not vital that we fix these, but we should certainly watch closely when we next migrate pinz.

  --Ethan McCutchen.....Sun Nov 15 16:40:57 -0800 2009

---

http://www.dwagn.org/wagn/George_Por+*email has caps in it.

  --John Abbe.....Wed Dec 02 14:40:42 -0800 2009

---

Also still with caps:

http://www.dwagn.org/wagn/Jillian_Ada_Burrows+*email

http://www.dwagn.org/wagn/Bobbi_Newman+*email

http://www.dwagn.org/wagn/Rory+*email

http://www.dwagn.org/wagn/Winston+*email

http://www.dwagn.org/wagn/TED_HAND+*email (and unlinked, like Markus Strauss etc. below)

http://www.dwagn.org/wagn/Paul_B_Hartzog+*email

http://www.dwagn.org/wagn/Kenneth_MacClune+*email

 

Has an email address, but it doesn't auto-link, which seems odd:

http://www.dwagn.org/wagn/Markus_Strauss+*email

 

And with no email at all:

http://www.dwagn.org/wagn/Johnny_Cake+*email

http://www.dwagn.org/wagn/TestUser+*email

http://www.dwagn.org/wagn/Bluser+*email

http://www.dwagn.org/wagn/Wagn_Bot+*email (intentional?)

  --John Abbe.....Wed Dec 02 14:47:58 -0800 2009

---

Everything else seems good.

 

We'll have to make sure to take care of this when implementing mass-import of account info. (didn't see a ticket for this in http://www.wagn.org/wagn/account+tickets_for_item but i know it's something we talked about)

  --John Abbe.....Wed Dec 02 15:04:18 -0800 2009

---

we made a new migration to fix the buggeredness. migrating now.

 

not too worried about mass-import, because I have it autodowncasing as part of validation.

  --Ethan McCutchen.....Thu Dec 03 10:12:58 -0800 2009

---

Has an email address, but it doesn't auto-link, which seems odd:

http://www.dwagn.org/wagn/Markus_Strauss+*email

 

http://www.dwagn.org/wagn/TED_HAND+*email (this one wasn't becoming a link, but now is)

 

No email at all:

http://www.dwagn.org/wagn/Johnny_Cake+*email

http://www.dwagn.org/wagn/TestUser+*email

http://www.dwagn.org/wagn/Bluser+*email

http://www.dwagn.org/wagn/Wagn_Bot+*email (intentional?)

  --John Abbe.....Thu Dec 03 15:36:09 -0800 2009

---

1. added eu to accepted domain endings. tested markus' email locally and it worked.

2. Guessing Ted's didn't work because .net was capitalized or something?

3. Wagn Bot is a system account and therefore doesn't have to have an email. Can if you want...

4. would be good to add emails to those other accounts on wagn.org. can be bogus1@bogus.com, bogus2... they'll get copied over to dwagn automatically eventually. we may want to do some data checking on other sites later on. Idea?

  --Ethan McCutchen.....Fri Dec 04 08:39:51 -0800 2009

---

1. Any reason not to allow all top level domains? (i can probably dig up a canonical list if that would be helpful; this would become a periodic task to check and update the list as they add domains)

3. Vague memory that some emails from a Wagn come from Wagn Bot's address if no other address is specified. If this is the case, then we probably do want something there.

4. (and 3.) Not seeing/thinking how to add addresses (or maybe were you suggesting it be an Idea because it requires console access?)

  --John Abbe.....Fri Dec 04 10:08:33 -0800 2009

---

1. it's not about disallowing accounts, it's about pattern matching within text. there's a list of domain endings that keeps us from matching things that aren't domains. +*email isn't special, it's just treated as normal text.

2. yeah, it uses wagbot if you don't have *account+*from or *notify+*from. Our sites should probably have those set. As for english and other sites, you can put something bogus in there if you want to, but please don't use any of our domains. I don't want to have a bunch of crap pinging noreply@wagn.org from other folks installations.

4. um, you add email addresses to a card with an account by clicking on the options tab on that card. if the card doesn't have an account, then you won't see the interface. Looks to me like that's the issue with at least some those cards: No account. Not all user cards have accounts. so let's forget about them.

  --Ethan McCutchen.....Fri Dec 04 10:34:48 -0800 2009

---

1. Bad choice of words. I meant, is there any reason not to match all ICANN-approved top level domains? Important for i18n among other things. Shall i create a ticket?

2. Pondering; don't really want to spam anyone else either.

  --John Abbe.....Fri Dec 04 12:56:48 -0800 2009