don't redirect after creating cards w xtion marks in name

Ticket

+commit
 

when you add a relative inclusion in place on a card ending with a question mark, then you get redirected upon saving to a plus card.

 

Changed URI.escape to CGI.escape in slot.url_for

 

URI escape doesn't escape question marks (or +, /, ~, etc).  See http://www.listable.org/show/difference-between-cgiescape-and-uriescape-in-ruby

 

 

 

 


need more specifics: what did you click, where did it take you?

  --Lewis Hoffman.....Wed May 06 09:58:58 -0700 2009


Lew, the page that John links to ( http://icah.wagn.org/wagn/Why_are_people_so_worked_up_about_sex ) has three inclusions. Creating any one of them incurs the redirection. (I was testing this yesterday and left it in a dirty state. My bad).

I don't get it, context seems to be right.

  --Ethan McCutchen.....Wed May 06 12:00:26 -0700 2009


(that example is gone now, but it happens with any "question" card on the site.

  --Ethan McCutchen.....Tue May 12 21:11:55 -0700 2009


raised the pri on this, because it's an issue on ICAH

  --Ethan McCutchen.....Mon May 18 21:04:23 -0700 2009


John Sechrest ran into it on http://seattleonfire.wagn.org/ as well.

  --John Abbe.....Tue Jun 09 08:55:36 -0700 2009


this seems to be happening on edits too-- for example editing the pointer to add a tag here did it to me. Phoebe ran into it on connectipedia as well.

  --Lewis Hoffman.....Wed Aug 12 15:53:16 -0700 2009