fix full size for uploaded gifs




We want to both fix newly uploaded images, and do a migration to fix existing ones.



I was poking around trying to better characterize this one, and first, we don't really seem to have any image files in the test database.  I was playing with adding a test based on *logo, but that's not ideal.

While poking around, it eventually did display that image after several double click edits and cancels.  I'm wondering exactly were the problem is, maybe in the browser/javascript?  Is the image missing from the server, or more likely, not always loading correctly into the slot.


You got an image beneath "content, size:full:" ? I double-clicked (and cancelled) a bunch and only ever managed to edit the whole "fullsize image testing" card, and the image never appeared.

  --John Abbe.....Thu Jan 06 02:52:26 -0800 2011

Probably good to ask Lew about this one, since he did this work and spotted this issue. But my memory was that the actual image was unavailable for some reason. Does seem bizarre that the problem would be with the original.

  --Ethan McCutchen.....Thu Jan 06 10:08:09 -0800 2011

Yeah, maybe the URL is getting munged somehow, so it doesn't actually point to the right file.

Yes, I did see the "full" image at one point, but I have no idea how I did it. I'll see if I can reproduce it.

  --Gerry Gleason.....Thu Jan 06 10:40:16 -0800 2011

just noticed that size is completely not respected in closed view (see example). expand this ticket, or add one?

  --John Abbe.....Mon Feb 28 09:39:58 -0800 2011

There are two issues there. One is that when you open and close image cards, the size variable is not getting passed as a cgi var. I think this is already ticketed (described as losing size when reopening or something). The other is that we explicitly override the size in css anyway so that images don't bust the closed view. Not sure that's a bad idea. No need to ticket that without a better one.

  --Ethan McCutchen.....Mon Feb 28 09:50:01 -0800 2011

yup, respect image size when closed view is opened


Right, I wasn't suggesting that when the card is actually in closed view it be anything other than icon size.

  --John Abbe.....Mon Feb 28 10:08:36 -0800 2011

I was thinking this would be covered by the upgrade in implement password security for files, but that may not be true based on this comment:


ImageScience doesn't handle all gifs properly, so it converts them to pngs for thumbnails. It has something to do with trying to save gifs with a larger palette than 256 colors, which is all the gif format supports. One fix would be switch to different image processing back-end (ImageMagick.. etc)


I think for now we're going to keep using ImageScience. Will dig in later, but taking off of 1.8 for now.

  --Ethan McCutchen.....Thu Dec 01 12:43:38 -0800 2011