handle validation in multi-edit card creation

Ticket

+commit
 

Thinking we want to not create the card if one of the multi-edit fields don't validate.

 

Another option is to create the card, but change "Create" to "Save" and of course allow it to save.

 

In any case, graphically highlighting the fields that need to be corrected would be nice.

 

redarrow

 

 

Add a recipe, give it a name, and type some letters into the "serves" field. When you click Create, you'll get a validation error that it should be a number. Correct it and click Create, and it tells you a card by that name already exists.

 

On http://test.dwagn.com/hoedads the first field is a Number. In multi-edit, I typed "hello" in that field, and when I saved, it just retained the old value - no error message. Content changes in other fields are also ignored. --John


hmm, looks to me like the other ones are saving, no?

  --Ethan McCutchen.....Wed Feb 01 15:53:33 -0800 2012


going to push this one off until 1.8.2. Most of the heavy lifting is done, but there is some attention to transactions needed.

  --Ethan McCutchen.....Wed Feb 01 16:27:25 -0800 2012


Actually, I fixed the key problem. Got it working locally. Pushing.

  --Ethan McCutchen.....Thu Feb 02 11:00:28 -0800 2012


Works for simple test, will bang a bit more later today. The error is not so helpful, especially for longer forms. Make a separate ticket for highlight fields failing validation in multi-edit ?

  --John Abbe.....Thu Feb 02 11:43:56 -0800 2012


what was the error message? I got a specific error in my trial.

  --Ethan McCutchen.....Thu Feb 02 13:09:58 -0800 2012


Rats. Issue with HOEDADS card:

HOEDADS+DOMAIN: 'hi' is not numeric

 

IMHO, something like this would be better:

 

Can't save "hoedads" because:

domain field: 'hi' is not numeric

 

But my main concern is that especially on a long form, having to scan through and find the problem fields makes a lot of work for the user. Highlighting fields that have a problem (say, with the the white-on-red arrow I made, above) would help a lot. Ideally, hovering over the arrow would pop up a note, such as: domain must be numeric

  --John Abbe.....Thu Feb 02 13:51:33 -0800 2012


ok, new ticket for that sounds good.

  --Ethan McCutchen.....Thu Feb 02 15:01:02 -0800 2012


improve error-handling when validating

  --John Abbe.....Thu Feb 02 15:56:30 -0800 2012


oh, sure. I was signing off on the earlier one. either ok. btw, did you see my skype reply?

  --Ethan McCutchen.....Thu Feb 02 15:59:19 -0800 2012