ignore invalid views

Ticket

+commit
 

Wagn currently raises an error if you have an invalid card view on an inclusion. Should just ignore invalid views, and use the default - view:content.

 

 

edit this and change "closed" to "blah":

 

view (blah) not supported for current

 

Well, I made it neither break nor ignore the invalid view.  it now gives a message that the view is not valid.


Makes sense. What do you think of styling the message the same light gray as "Add |cardname|", and prepending the cardname, something like:

|Cardname| - unknown card view: 'foo'

  --John Abbe.....Thu Mar 26 12:17:42 -0700 2009


The name's not a bad idea (though introduces slightly higher chance of bugginess), but I'd rather go bold than grey -- if the view is invalid it should be fixed right away.

  --Ethan McCutchen.....Thu Mar 26 13:04:21 -0700 2009


(made that change)

  --Ethan McCutchen.....Thu Mar 26 13:05:46 -0700 2009


I was thinking the gray would match the "Add |cardname|". If we want to go prominent, i'm wondering if bold is enough - maybe bold and red? :-)

Ah, how about gray the cardname and leave the rest bold?

  --John Abbe.....Thu Mar 26 13:13:09 -0700 2009


do we have any tickets about formatting error messages? This is basically an error message, so if anything we should be changing it to match other error messages, all of which could use some formatting work. This is not one of the worse ones. And while we're at it, we may want to move more of them into cards, which will speed the process of internationalizing wagns. (new.wagn.org may eventually become en.wagn.org, and we may make it easy for people to contribute other language templates via cards).

at any rate, good ideas, but I should stop putting off the big tickets. If you'd like to start tracking error formatting ideas somewhere, that would be awesome. If not I know it will come back up soon. There are unattractive errors all over.

  --Ethan McCutchen.....Thu Mar 26 15:01:19 -0700 2009


created Idea for clearer and more harmonious error messages; and closing

  --John Abbe.....Fri Apr 03 16:31:14 -0700 2009