refactor card slots

Ticket

refactor card slots+status
refactor card slots+priority
refactor card slots+commit
 

refactor card slots+issues

card-slots, the spaces where we insert card content, are handled inconsistently, which leading to problems in formatting and behavior. 

 

As it currently stands, some card views are rendered with no formal slot.  When it does appear, the slot itself contains information about the state of the card, which means the slot itself has to be changed or replaced whenever the state is changed.

 

On first save, many issues, including:

  • double-click isn't triggering edit
  • inline not being rendered properly
  • unwanted horizontal line appearing
  • ??

Also:

 

refactor card slots+solution

Outer tag: <card card-id="number" position="number" home="viewname">

Inner tag: <div class="viewname-view SET-classes">

 

We'll create an outer slot (the nest?) which does nothing but identify the card (by id, since name can change) and its position.  This will not be changed, replaced, or updated unless the context nesting the slot is updated.

 

Then there will be an inner slot that holds changeable information about the card, including view, type, name, etc.  Whenever the card is updated the inner slot will be replaced.

 

update wrapper CSS for current terminology and maybe more would be good to do at the same time

 

refactor card slots+example

content view inclusions next to images messed up in edit mode:

 

nymph

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

 

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

 

nymph

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

 

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

 

I'm not clear on what happens wrt inline v. block on these slots.  it seems like the outer will often need to be inline, but if it's always inline, won't that cause problems in IE?  Can we create a new html tag for it?  <nest> or something?  would that solve anything?


much more useful to have examples on test.dwagn.org.

  --Ethan McCutchen.....Tue Dec 14 09:57:24 -0800 2010


I'm not sure the solution above will work. The outer slot must be either a block element or an inline element, no? I think most browsers will choose one or the other, even if we make it a tag, but that merits exploration. Anyway, either will potentially create issues. we should do some serious browser testing before we do any coding.

  --Ethan McCutchen.....Tue Dec 14 10:05:35 -0800 2010


is refactor inclusion processing part of this?

  --John Abbe.....Sat Jan 22 15:17:27 -0800 2011


not really. what we're doing is definitely a refactor of the slot apparatus underneath, but this is talking about generating different html and handling it differently, which we're not doing.

  --Ethan McCutchen.....Sat Jan 22 15:26:11 -0800 2011


took browser screenshots: http://crossbrowsertesting.com/users/ethan/screenshots/43168/57483

  --Ethan McCutchen.....Thu Mar 10 16:23:23 -0800 2011


"Access denied. You may need to login below or register to access this page."

  --John Abbe.....Fri Mar 11 16:17:05 -0800 2011


http://crossbrowsertesting.com/users/26675/screenshots/zaf704171a8cc59f7b69/public

  --Ethan McCutchen.....Fri Mar 11 16:20:42 -0800 2011