I would have thought this issue was already ticketted. I don't think it matters whether it is a *structure case (form), this is the same problem when adding a +discussion card. Note no signature.
What did you do to create that comment? Did you edit the whole card?
No, just clicked the "Add +discussion" link. The basic problem is that when you are creating the +discussion card, it doesn't post as a comment action, so none of the signature stuff gets invoked. It doesn't matter if it is part of a multi-edit form or just an add-link like I just did here.
Weird. I thought the work Ethan had done to add sigs when people add the first comment via the discussion menu item had made the sig appear in some other cases, but I guess not.
if you add as part of a form submission, it never adds a sig. But if you add show:comment_box to a +discussion inclusion, you'll always get the comment box (and never the +discussion link), and the sig is added every time.
This is just the beginning of the steps outlined in commenting overhaul. That overhaul doesn't deal with the idea that a sig should be added when the discussion is created as part of a form. Is that really desirable?
I think I'm coming around to agreeing about forms. just to throw it out there, another possibility is that the form include the edit area *and* the comment box. not sure I like it... in fact, I suspect I don't :)
yeah that sounds fugly, I think I'd rather not have the sig. Would events offer a solution once they're implemented? (on save of a form, check if any of the fields show comment_box, and if so, append a sig line)
That's totally impossible to figure out (discoverability). Does it make sense for only very specific view like that? Or is that just the easier to implement?
I'm not sure I agree this is desirable. Editing the discussion card and commenting on the discussion are two different things. It seems clear to me that you should get the edit interface when editing the whole and the comment box should only show up in "read" views.
It also seems clear that not all views should show the comment box at the bottom. not error views, not history, not change, name, etc. If there are specific views where we want to add them, that's one thing. But I think the current solution actually makes more sense than anything else proposed so far.
I'm going to close this as a support ticket. Feel free to weigh in on the commenting overhaul blueprint or add ideas (and connect them to the blueprint) if there's something here you want to push for.
add signature to first comment via form
Support Ticket
+issues
Right now if you add a card with +discussion in it's controlling +*structure and put some content in the +discussion, it doesn't get a signature.
http://test.dwagn.org/new/User
I would have thought this issue was already ticketted. I don't think it matters whether it is a *structure case (form), this is the same problem when adding a +discussion card. Note no signature.
What did you do to create that comment? Did you edit the whole card?
No, just clicked the "Add +discussion" link. The basic problem is that when you are creating the +discussion card, it doesn't post as a comment action, so none of the signature stuff gets invoked. It doesn't matter if it is part of a multi-edit form or just an add-link like I just did here.
Weird. I thought the work Ethan had done to add sigs when people add the first comment via the discussion menu item had made the sig appear in some other cases, but I guess not.
if you add as part of a form submission, it never adds a sig. But if you add show:comment_box to a +discussion inclusion, you'll always get the comment box (and never the +discussion link), and the sig is added every time.
This is just the beginning of the steps outlined in commenting overhaul. That overhaul doesn't deal with the idea that a sig should be added when the discussion is created as part of a form. Is that really desirable?
It's totally an edge case, but I do think it is desirable. Our Support Tickets didn't have show:comment_box, so I just fixed that anyway.
I tried the show:comment_box here and it seems to be broken. Is that a new issue, or am I just missing something?
currently supported in open / titled only.
I think I'm coming around to agreeing about forms. just to throw it out there, another possibility is that the form include the edit area *and* the comment box. not sure I like it... in fact, I suspect I don't :)
yeah that sounds fugly, I think I'd rather not have the sig. Would events offer a solution once they're implemented? (on save of a form, check if any of the fields show comment_box, and if so, append a sig line)
That's totally impossible to figure out (discoverability). Does it make sense for only very specific view like that? Or is that just the easier to implement?
weigh in on specs on commenting overhaul.
I'm not sure I agree this is desirable. Editing the discussion card and commenting on the discussion are two different things. It seems clear to me that you should get the edit interface when editing the whole and the comment box should only show up in "read" views.
It also seems clear that not all views should show the comment box at the bottom. not error views, not history, not change, name, etc. If there are specific views where we want to add them, that's one thing. But I think the current solution actually makes more sense than anything else proposed so far.
I'm going to close this as a support ticket. Feel free to weigh in on the commenting overhaul blueprint or add ideas (and connect them to the blueprint) if there's something here you want to push for.