interpret spaces in *home as underscores

Ticket

+commit
2b9849b2
 

Right now if *title has spaces in it and there's no *home, the spaces are interpreted as underscores. But spaces in *home are interpreted as +s.

 

 

Try it on TEST. Delete http://test.dwagn.org/card/edit/*home and go home and it works. Then recreate *home with "test me" and it goes to "test+me".

 

I think my redirection patch probably fixed this.


Nope.

  --John Abbe.....Fri Feb 11 21:14:12 -0800 2011


Now it interprets the space in "test me" as an underscore, but when there's no *home card there's an app error. Hoptoad says NoMethodError: undefined method `to_url_key' for nil:NilClass.

 

(It should fall back to *title, and without *title fall back to...Home? Hm, guessing we want an ultimate fallback in code, even though that will obviously require code-editing to translate.)

  --John Abbe.....Sun Feb 20 15:44:22 -0800 2011


I'm fine with requiring a *home card. Soon we'll be able to make it impossible to delete. In any case, separate issue, right?

  --Ethan McCutchen.....Sun Feb 20 21:33:31 -0800 2011


btw, I'm ok if our worst-case-scenario fallbacks are hard-coded English. If we're saying that *home cards are required and shouldn't be deleted, but we make it so that if someone somehow manages to do so it shows a "Home" card, I think we're doing fine, no?

  --Ethan McCutchen.....Mon Feb 21 10:17:23 -0800 2011


hard-code main page to "Home" if no *home

  --John Abbe.....Mon Feb 21 10:24:07 -0800 2011