narrow inclusions to not cover float right images

Ticket

+commit
 

 

 

With the 0.13 code, these are fine... :

 

nymph

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

 

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

 

nymph

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

 

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

 

...but these are problematic when editing:

 

nymph

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

 

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

 

nymph

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

 

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

 

nothing is "covered", as far as I can tell.  still a problem?


I don't know about you, but the nymph image in +example is almost covered from the bottom to her blue headband for me.

  --John Abbe.....Mon Dec 15 04:31:52 -0800 2008


Still busted; see http://sandwagn.wagn.org/wagn/narrow_inclusion_to_not_cover_float_right_image

(I'm in Firefox 2 if you think that may make a difference.)

  --John Abbe.....Mon Dec 22 21:01:52 -0800 2008


if you take the width: 100% out of card slot, it seems to fix this.

  --Ethan McCutchen.....Tue Feb 24 20:36:11 -0800 2009


IE6 still needs that 100%, so I put in browser-specific css. That fix addresses most of the view problems (at least in non-IE browsers). there are still edit problems, and it looks to me like we'll be able to fix them once we refactor the slot system, but probably not until.

  --Ethan McCutchen.....Fri Mar 13 18:43:27 -0700 2009


Looks fine now if the text is included open or closed. With content view, as you say, edit is broken (just visually for float:right, but with float:left you can't even see all of what you're editing). I've updated the examples to show this.

The examples have display:block in them - is this still relevant at all?

Suggest we close this and add a note about this to the slot system refactoring ticket - what's it called?

  --John Abbe.....Tue Mar 24 18:25:01 -0700 2009


(tested on http://new.wagn.org/wagn/DeleteMe+new )

  --John Abbe.....Tue Mar 24 18:30:07 -0700 2009


sounds good. ticket is called refactor card slots

  --Ethan McCutchen.....Tue Mar 24 21:56:31 -0700 2009